Arik Hadas has uploaded a new change for review.

Change subject: webadmin: remove unneeded query for template's disks
......................................................................

webadmin: remove unneeded query for template's disks

Change-Id: I9d3979b4a4559ff0ce196016d95d13bc1b07a170
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
1 file changed, 11 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/46/33146/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
index de3019b..4e3e346 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
@@ -2132,31 +2132,19 @@
         {
             model.startProgress(null);
 
-            AsyncQuery _asyncQuery = new AsyncQuery();
-            _asyncQuery.setModel(this);
-            _asyncQuery.asyncCallback = new INewAsyncCallback() {
-                @Override
-                public void onSuccess(Object model1, Object result1)
-                {
-                    VmListModel vmListModel = (VmListModel) model1;
-                    UnitVmModel unitVmModel = (UnitVmModel) 
vmListModel.getWindow();
+            VM vm = getcurrentVm();
+            
vm.setUseLatestVersion(constants.latestTemplateVersionName().equals(model.getTemplate().getSelectedItem().getTemplateVersionName()));
 
-                    VM vm = vmListModel.getcurrentVm();
-                    
vm.setUseLatestVersion(constants.latestTemplateVersionName().equals(unitVmModel.getTemplate().getSelectedItem().getTemplateVersionName()));
+            VmManagementParametersBase param = new 
VmManagementParametersBase(vm);
+            
param.setDiskInfoDestinationMap(model.getDisksAllocationModel().getImageToDestinationDomainMap());
+            
param.setSoundDeviceEnabled(model.getIsSoundcardEnabled().getEntity());
+            
param.setVirtioScsiEnabled(model.getIsVirtioScsiEnabled().getEntity());
+            
param.setConsoleEnabled(model.getIsConsoleDeviceEnabled().getEntity());
+            param.setBalloonEnabled(balloonEnabled(model));
+            
param.setCopyTemplatePermissions(model.getCopyPermissions().getEntity());
+            setRngDeviceToParams(model, param);
 
-                    VmManagementParametersBase param = new 
VmManagementParametersBase(vm);
-                    
param.setDiskInfoDestinationMap(unitVmModel.getDisksAllocationModel().getImageToDestinationDomainMap());
-                    
param.setSoundDeviceEnabled(model.getIsSoundcardEnabled().getEntity());
-                    
param.setVirtioScsiEnabled(model.getIsVirtioScsiEnabled().getEntity());
-                    
param.setConsoleEnabled(model.getIsConsoleDeviceEnabled().getEntity());
-                    param.setBalloonEnabled(balloonEnabled(model));
-                    
param.setCopyTemplatePermissions(model.getCopyPermissions().getEntity());
-                    setRngDeviceToParams(model, param);
-
-                    
Frontend.getInstance().runAction(VdcActionType.AddVmFromTemplate, param, new 
UnitVmModelNetworkAsyncCallback(model, defaultNetworkCreatingManager), 
vmListModel);
-                }
-            };
-            AsyncDataProvider.getInstance().getTemplateDiskList(_asyncQuery, 
getcurrentVm().getVmtGuid());
+            Frontend.getInstance().runAction(VdcActionType.AddVmFromTemplate, 
param, new UnitVmModelNetworkAsyncCallback(model, 
defaultNetworkCreatingManager), this);
         }
         else
         {


-- 
To view, visit http://gerrit.ovirt.org/33146
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d3979b4a4559ff0ce196016d95d13bc1b07a170
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to