Arik Hadas has posted comments on this change. Change subject: core,webadmin: show list of changed fields when updating running vm ......................................................................
Patch Set 2: (2 comments) looks ok, minor comments http://gerrit.ovirt.org/#/c/33046/2/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java: Line 230: * @param status Line 231: * The status. Line 232: */ Line 233: private static void LogError(String name, Enum<?> status) { Line 234: log.warnFormat("Field {0} can not be updated when status is {1}", name, status); it is a bit weird to log something as a warning in 'LogError' :) can we change it to LogWarning or something like that? Line 235: } Line 236: Line 237: private static final Log log = LogFactory.getLog(ObjectIdentityChecker.class); http://gerrit.ovirt.org/#/c/33046/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java: Line 1919: Line 1920: @DefaultStringValue("SPICE-HTML5 does not support SPICE Proxy.") Line 1921: String spiceHtml5DoesntSupportSpiceProxy(); Line 1922: Line 1923: @DefaultStringValue("Changed fields list") do we need the 'list' word? Line 1924: String changedFieldsList(); -- To view, visit http://gerrit.ovirt.org/33046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf13a19d1b193037226cb49bc6c1e8cefc0553b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
