Yaniv Bronhaim has uploaded a new change for review. Change subject: webadmin: NPE in Picking first provider ......................................................................
webadmin: NPE in Picking first provider Fix assumption that first provider exists Change-Id: I71d1249d86a6b700708391eb19ba98302dd0be4a Signed-off-by: Yaniv Bronhaim <ybron...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/92/33092/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java index 52cf6a4..a88ce33 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java @@ -13,6 +13,7 @@ import org.ovirt.engine.core.common.mode.ApplicationMode; import org.ovirt.engine.ui.frontend.AsyncQuery; import org.ovirt.engine.ui.frontend.INewAsyncCallback; +import org.ovirt.engine.ui.uicommonweb.Linq; import org.ovirt.engine.ui.uicommonweb.dataprovider.AsyncDataProvider; import org.ovirt.engine.ui.uicommonweb.models.ApplicationModeHelper; import org.ovirt.engine.ui.uicommonweb.models.ListModel; @@ -156,11 +157,10 @@ { ArrayList<Provider> providers = (ArrayList<Provider>) result; ListModel<Provider> providersListModel = getProviders(); - providersListModel.setItems(providers); + providersListModel.setItems(providers, Linq.firstOrDefault(providers)); providersListModel.setIsChangable(true); - providersListModel.setSelectedItem(providers.get(0)); - getIsDiscorveredHosts().setEntity(null); - getIsDiscorveredHosts().setEntity(true); + getIsDiscoveredHosts().setEntity(null); + getIsDiscoveredHosts().setEntity(true); } }; AsyncDataProvider.getAllProvidersByType(getProvidersQuery, ProviderType.FOREMAN); -- To view, visit http://gerrit.ovirt.org/33092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I71d1249d86a6b700708391eb19ba98302dd0be4a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches