Sahina Bose has posted comments on this change. Change subject: bll: stop and delete geo-rep session ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/33038/2/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DeleteGeoRepSessionCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DeleteGeoRepSessionCommandTest.java: Line 9: import org.mockito.runners.MockitoJUnitRunner; Line 10: import org.ovirt.engine.core.common.action.gluster.GlusterVolumeGeoRepSessionParameters; Line 11: Line 12: @RunWith(MockitoJUnitRunner.class) Line 13: public class DeleteGeoRepSessionCommandTest extends GeoRepSessionCommandTest { > test case for executeCommand ?? executeCommand has not much logic now. everything needs to be mocked. Line 14: Line 15: /** Line 16: * The command under test. Line 17: */ http://gerrit.ovirt.org/#/c/33038/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeGeoRepSessionParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeGeoRepSessionParameters.java: Line 1: package org.ovirt.engine.core.common.action.gluster; Line 2: Line 3: import org.ovirt.engine.core.compat.Guid; Line 4: Line 5: public class GlusterVolumeGeoRepSessionParameters extends GlusterVolumeParameters{ > I feel we can have a base class with members slaveHostName, slaveVolumeName this is the base class :) Line 6: Line 7: private static final long serialVersionUID = -881348048838907389L; Line 8: Line 9: private Guid geoRepSessionId; -- To view, visit http://gerrit.ovirt.org/33038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I537a11bde7c412599a00269d44764f554bb4618d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
