Maor Lipchuk has posted comments on this change. Change subject: core: Use the latest OVF_STORE files ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/32747/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 220: if (retrievedByteData.getSucceeded()) { Line 221: ovfEntitiesFromTar = Line 222: OvfUtils.getOvfEntities((byte[]) retrievedByteData.getReturnValue(), Line 223: getParameters().getStorageDomainId()); Line 224: entitiesRetrieved = true; > you should return here, done Line 225: } else { Line 226: log.errorFormat("Image data could not be retrieved for disk id {0} in storage domain id {1}", Line 227: ovfDisk.getId(), Line 228: getParameters().getStorageDomainId()); -- To view, visit http://gerrit.ovirt.org/32747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8252281f295df49a28c3c131d9a98fef9af8f35e Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
