Maor Lipchuk has posted comments on this change. Change subject: core: Verify that date is initialized in OVF_STORE disk ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/32963/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 342: } Line 343: Line 344: private Date getDateFromDiskDescription(Map<String, Object> map) { Line 345: try { Line 346: if (getLastUpdate(map) != null) { > please export to a variable and eliminate the method done Line 347: return new SimpleDateFormat(OvfParser.formatStrFromDiskDescription).parse(getLastUpdate(map).toString()); Line 348: } else { Line 349: log.info("LastUpdate Date is not initialized in the OVF_STORE disk."); Line 350: } Line 345: try { Line 346: if (getLastUpdate(map) != null) { Line 347: return new SimpleDateFormat(OvfParser.formatStrFromDiskDescription).parse(getLastUpdate(map).toString()); Line 348: } else { Line 349: log.info("LastUpdate Date is not initialized in the OVF_STORE disk."); > please move this log to line 322 I want to distinguish between an error from Exception parsing the OVF to a scenario where there is no date in the disk description. Line 350: } Line 351: } catch (java.text.ParseException e) { Line 352: log.errorFormat("LastUpdate Date could not be parsed from disk desscription. Exception: {0}", e); Line 353: } -- To view, visit http://gerrit.ovirt.org/32963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e59086ce7242d7aaec10b57b6775ab968c9fe1c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
