Sahina Bose has posted comments on this change. Change subject: engine : VdsCommand for geo-rep session resume ......................................................................
Patch Set 3: (9 comments) http://gerrit.ovirt.org/#/c/32933/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 298: GLUSTER_VOLUME_REBALANCE_START_FAILED(4013, AuditLogSeverity.ERROR), Line 299: GLUSTER_VOLUME_REMOVE_BRICKS(4014), Line 300: GLUSTER_VOLUME_REMOVE_BRICKS_FAILED(4015, AuditLogSeverity.ERROR), Line 301: GLUSTER_VOLUME_GEO_REP_RESUME_FAILED(4597, AuditLogSeverity.ERROR), Line 302: GLUSTER_VOLUME_GEO_REP_RESUME(4596), Move out of this patch to BLL command patch Line 303: GLUSTER_VOLUME_REPLACE_BRICK_FAILED(4016, AuditLogSeverity.ERROR), Line 304: GLUSTER_VOLUME_REPLACE_BRICK_START(4017), Line 305: GLUSTER_VOLUME_REPLACE_BRICK_START_FAILED(4018, AuditLogSeverity.ERROR), Line 306: GLUSTER_VOLUME_ADD_BRICK(4019), http://gerrit.ovirt.org/#/c/32933/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 299: StartRemoveGlusterVolumeBricks(1422, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Line 300: StopRemoveGlusterVolumeBricks(1423, ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE), Line 301: CommitRemoveGlusterVolumeBricks(1424, ActionGroup.MANIPULATE_GLUSTER_VOLUME, false, QuotaDependency.NONE), Line 302: RefreshGlusterVolumeDetails(1425, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Line 303: ResumeGeoRepGlusterVolume(1426, ActionGroup.MANIPULATE_GLUSTER_VOLUME, QuotaDependency.NONE), Move out of this patch to the BLL command patch Line 304: Line 305: // Scheduling Policy Line 306: AddClusterPolicy(1450, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), Line 307: EditClusterPolicy(1451, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), http://gerrit.ovirt.org/#/c/32933/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java: Line 372: GlusterVolumeOptionInfoFailed(4154), Line 373: GlusterVolumeResetOptionsFailed(4155), Line 374: GlusterVolumeRemoveBricksFailed(4156), Line 375: GlusterVolumeRemoveBricksStartFailed(4140), Line 376: GlusterVolumeGeoRepResumeFailed(4597), Please add this to the end of gluster errors (in the order of code) Line 377: GlusterVolumeStatusFailed(4157), Line 378: GlusterVolumeProfileStartFailed(4158), Line 379: GlusterVolumeProfileStopFailed(4159), Line 380: GlusterVolumeProfileInfoFailed(4160), http://gerrit.ovirt.org/#/c/32933/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 88: VAR__ACTION__LOGON, Line 89: VAR__ACTION__LOGOFF, Line 90: VAR__ACTION__REBALANCE_START, Line 91: VAR__ACTION__REBALANCE_STOP, Line 92: VAR_ACTION_GEO_REP_RESUME, Move out of this patch to BLL command patch Line 93: VAR__ACTION__REMOVE_BRICKS_START, Line 94: VAR__ACTION__ASSIGN, Line 95: VAR__ACTION__START_PROFILE, Line 96: VAR__ACTION__STOP_PROFILE, http://gerrit.ovirt.org/#/c/32933/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java: Line 131: StopRemoveGlusterVolumeBricks("org.ovirt.engine.core.vdsbroker.gluster"), Line 132: CommitRemoveGlusterVolumeBricks("org.ovirt.engine.core.vdsbroker.gluster"), Line 133: StartRebalanceGlusterVolume("org.ovirt.engine.core.vdsbroker.gluster"), Line 134: StopRebalanceGlusterVolume("org.ovirt.engine.core.vdsbroker.gluster"), Line 135: ResumeGeoRepGlusterVolume("org.ovirt.engine.core.vdsbroker.gluster"), ResumeGeoRepSession ? Line 136: AddBricksToGlusterVolume("org.ovirt.engine.core.vdsbroker.gluster"), Line 137: ReplaceGlusterVolumeBrick("org.ovirt.engine.core.vdsbroker.gluster"), Line 138: RemoveGlusterServer("org.ovirt.engine.core.vdsbroker.gluster"), Line 139: AddGlusterServer("org.ovirt.engine.core.vdsbroker.gluster"), http://gerrit.ovirt.org/#/c/32933/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeResumeGeoRepVDSParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeResumeGeoRepVDSParameters.java: Line 1: package org.ovirt.engine.core.common.vdscommands.gluster; Line 2: Line 3: import org.ovirt.engine.core.compat.Guid; Line 4: Line 5: public class GlusterVolumeResumeGeoRepVDSParameters extends GlusterVolumeVDSParameters { There's no need of a separate parameter class. Can you not reuse GlusterVolumeGeoRepSessionVDSParameters? Line 6: Line 7: private String slaveHostName; Line 8: private String slaveVolumeName; Line 9: private boolean force; http://gerrit.ovirt.org/#/c/32933/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java: Line 308: StatusOnlyReturnForXmlRpc setNumberOfCpus(String vmId, String numberOfCpus); Line 309: Line 310: StatusOnlyReturnForXmlRpc updateVmPolicy(Map info); Line 311: Line 312: StatusOnlyReturnForXmlRpc resumeGeoRepGlusterVolume(String volumeName, String slaveHostName, String slaveVolumeName, boolean force); Shouldn't this be glusterVolumeGeoRepResume ? http://gerrit.ovirt.org/#/c/32933/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java: Line 231: boolean force); Line 232: Line 233: public Map<String, Object> glusterVolumeRebalanceStart(String volumeName, Boolean fixLayoutOnly, Boolean force); Line 234: Line 235: public Map<String, Object> resumeGeoRepGlusterVolume(String volumeName, String slaveHostName, String slaveVolumeName, boolean force); glusterVolumeGeoRepResume? Line 236: Line 237: public Map<String, Object> glusterVolumeRebalanceStop(String volumeName); Line 238: Line 239: public Map<String, Object> replaceGlusterVolumeBrickStart(String volumeName, String existingBrickDir, String newBrickDir); http://gerrit.ovirt.org/#/c/32933/3/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java: Line 718: Line 719: @DefaultStringValue("Gluster Volume Rebalance Start Failed.") Line 720: String GlusterVolumeRebalanceStartFailed(); Line 721: Line 722: @DefaultStringValue("Gluster Volume geo-replication resume failed") Resume of geo-replication session failed on gluster volume ? Line 723: String GlusterVolumeGeoRepResumeFailed(); Line 724: Line 725: @DefaultStringValue("Gluster Volume Rebalance Stop Failed.") Line 726: String GlusterVolumeRebalanceStopFailed(); -- To view, visit http://gerrit.ovirt.org/32933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf1724dffbb4023e51a73d7262596f92bacb8698 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
