Roy Golan has posted comments on this change. Change subject: core: fix numa node distance persist ......................................................................
Patch Set 5: (4 comments) http://gerrit.ovirt.org/#/c/32901/5/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java: Line 195: return new Pair<Guid, Integer>(getGuid(rs, "numa_node_id"), rs.getInt("cpu_core_id")); Line 196: } Line 197: }; Line 198: Line 199: private static Map<Integer, Integer> getDistanceMap(String distance) { please comment the parsing scheme Line 200: Map<Integer, Integer> nodeDistance = new HashMap<>(); Line 201: if (StringUtils.isBlank(distance)) { Line 202: return nodeDistance; Line 203: } Line 203: } Line 204: String[] distanceArray = distance.split(";"); Line 205: for (int i = 0; i < distanceArray.length; i++) { Line 206: String[] nodeDistanceArray = distanceArray[i].split(","); Line 207: nodeDistance.put(Integer.valueOf(nodeDistanceArray[0]), Integer.valueOf(nodeDistanceArray[1])); you keep putting in under the same key? Line 208: } Line 209: return nodeDistance; Line 210: } Line 211: http://gerrit.ovirt.org/#/c/32901/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 1657: numaNode.setMemTotal(memTotal); Line 1658: newNumaNodeList.add(numaNode); Line 1659: } Line 1660: Line 1661: Collections.sort(newNumaNodeList, new Comparator<VdsNumaNode>() { any reason the NumaNode couldn't implement Comparator and we could also save the instance creation? and the code would be Collections.sort(list) Line 1662: Line 1663: @Override Line 1664: public int compare(VdsNumaNode arg0, VdsNumaNode arg1) { Line 1665: return arg0.getIndex() < arg1.getIndex() ? -1 : 1; Line 1671: int index = vdsNumaNode.getIndex(); Line 1672: List<Integer> distances = extractIntegerList(numaNodeDistanceMap, String.valueOf(index)); Line 1673: Map<Integer, Integer> distanceMap = new HashMap<>(distances.size()); Line 1674: for (int i = 0; i < distances.size(); i++) { Line 1675: distanceMap.put(newNumaNodeList.get(i).getIndex(), distances.get(i)); could you change that to regular java foreach? Line 1676: } Line 1677: VdsNumaNode newNumaNode = NumaUtils.getVdsNumaNodeByIndex(newNumaNodeList, index); Line 1678: if (newNumaNode != null) { Line 1679: newNumaNode.setNumaNodeDistances(distanceMap); -- To view, visit http://gerrit.ovirt.org/32901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3df943ef0a655b1250ebeade8caa7711b612440 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
