Alon Bar-Lev has posted comments on this change. Change subject: kdump: Remove dependencies on unreleased kexec-tools ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/33025/1/ovirt-host-deploy-offline.spec.in File ovirt-host-deploy-offline.spec.in: Line 46: %endif Line 47: %endif Line 48: %if 0%{?rhel} Line 49: %if %{rhel} == 6 Line 50: Requires: kexec-tools >= 2.0.0-273 why do we touch rhel-6, don't we support it as-is? Line 51: %endif Line 52: %if %{rhel} == 7 Line 53: Requires: kexec-tools >= 2.0.4-32 Line 54: %endif Line 49: %if %{rhel} == 6 Line 50: Requires: kexec-tools >= 2.0.0-273 Line 51: %endif Line 52: %if %{rhel} == 7 Line 53: Requires: kexec-tools >= 2.0.4-32 if we do not support rhel-7 why do we need this? Line 54: %endif Line 55: %endif Line 56: Line 57: %description http://gerrit.ovirt.org/#/c/33025/1/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 144 Line 145 Line 146 Line 147 Line 148 didn't you say you need to update this? -- To view, visit http://gerrit.ovirt.org/33025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24b97d512cf4dc7d0f250c933389e6ba811597cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
