Martin Mucha has posted comments on this change. Change subject: core,webadmin: enforce that label cannot be added to external network ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/32825/3/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java: Line 298: } Line 299: Line 300: @Test Line 301: public void networkNameNoNetworks() throws Exception { Line 302: networkNameAvailableTest(isValid(), Collections.<Network>emptyList()); > all the formatting changes are irrelevant and if i'm not wrong, omitting th probably code format importer from eclipse isn't that good. I've set rule for this, so this should not happen in advance. At least I hope it won't. Line 303: } Line 304: Line 305: @Test Line 306: public void networkNameAvailable() throws Exception { -- To view, visit http://gerrit.ovirt.org/32825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c697a06afa15ff5c31c0396d0744c9c456c2dc9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
