Roy Golan has posted comments on this change. Change subject: engine: NUMA feature transaction support ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/28241/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 931: Line 932: protected void addVmNumaNodes() { Line 933: List<VmNumaNode> numaNodes = getParameters().getVmStaticData().getvNumaNodeList(); Line 934: VmNumaNodeOperationParameters params = new VmNumaNodeOperationParameters(getVmId(), numaNodes); Line 935: getBackend().runInternalAction(VdcActionType.AddVmNumaNodes, params); compensation problem here. AddNumaNodes command doesn't support compensation. if the engine shutsdown/restart after the first TX call, we're left with junk vm numa records in db Line 936: } Line 937: Line 938: protected void addVmInit() { Line 939: VmHandler.addVmInitToDB(getParameters().getVmStaticData()); Line 932: protected void addVmNumaNodes() { Line 933: List<VmNumaNode> numaNodes = getParameters().getVmStaticData().getvNumaNodeList(); Line 934: VmNumaNodeOperationParameters params = new VmNumaNodeOperationParameters(getVmId(), numaNodes); Line 935: getBackend().runInternalAction(VdcActionType.AddVmNumaNodes, params); Line 936: } > had several issues, please refer to http://gerrit.ovirt.org/#/c/32904/ can you fixup 32904 to this patch and upload? Line 937: Line 938: protected void addVmInit() { Line 939: VmHandler.addVmInitToDB(getParameters().getVmStaticData()); Line 940: } -- To view, visit http://gerrit.ovirt.org/28241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If84e59fa38c9174fe7150116bf3c8832f7fac1dd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
