Shubhendu Tripathi has posted comments on this change. Change subject: engine: VDS commands for volume geo-rep status and detail ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/31799/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java: Line 7: import org.ovirt.engine.core.common.businessentities.gluster.GlusterGeoRepSession; Line 8: import org.ovirt.engine.core.common.businessentities.gluster.GlusterGeoRepSessionDetails; Line 9: Line 10: Line 11: public class GlusterVolumeGeoRepStatusDetailForXmlRpc extends GlusterVolumeGeoRepStatusForXmlRpc{ Ctrl + Shift + f required ?? Line 12: Line 13: private static final String FILES_SYNCED = "filesSyncd"; Line 14: private static final String FILES_PENDING = "filesPending"; Line 15: private static final String BYTES_PENDING = "bytesPending"; Line 9: Line 10: Line 11: public class GlusterVolumeGeoRepStatusDetailForXmlRpc extends GlusterVolumeGeoRepStatusForXmlRpc{ Line 12: Line 13: private static final String FILES_SYNCED = "filesSyncd"; Is the field name filesSyncd returned from VDSM or filesSynced?? Line 14: private static final String FILES_PENDING = "filesPending"; Line 15: private static final String BYTES_PENDING = "bytesPending"; Line 16: private static final String DELETES_PENDING = "deletesPending"; Line 17: private static final String FILES_SKIPPED = "filesSkipped"; http://gerrit.ovirt.org/#/c/31799/7/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java: Line 798: @DefaultStringValue("Failed to get gluster volume rebalance status") Line 799: String GlusterVolumeRebalanceStatusFailedException(); Line 800: Line 801: @DefaultStringValue("Failed to get gluster volume geo-replication status") Line 802: String GlusterVolumeGeoRepStatusDFailed(); %s/GlusterVolumeGeoRepStatusDFailed/GlusterVolumeGeoRepStatusFailed/g Line 803: Line 804: @DefaultStringValue("Failed to get gluster volume geo rep status detail") Line 805: String GlusterVolumeGeoRepStatusDetailFailed(); Line 806: -- To view, visit http://gerrit.ovirt.org/31799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id313742c9f3c036a0017fe37bd818af1bed0e081 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
