Daniel Erez has posted comments on this change. Change subject: webadmin: NPE in Picking first provider ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/32946/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java: Line 154: @Override Line 155: public void onSuccess(Object model, Object result) Line 156: { Line 157: ArrayList<Provider> providers = (ArrayList<Provider>) result; Line 158: ListModel providersListModel = getProviders(); please add back the generics (<Provider>) Line 159: providersListModel.setItems(providers); Line 160: providersListModel.setIsChangable(true); Line 161: getIsDiscoveredHosts().setEntity(null); Line 162: getIsDiscoveredHosts().setEntity(true); Line 155: public void onSuccess(Object model, Object result) Line 156: { Line 157: ArrayList<Provider> providers = (ArrayList<Provider>) result; Line 158: ListModel providersListModel = getProviders(); Line 159: providersListModel.setItems(providers); in order to make sure first item is selected if do exist, change to: providersListModel.setItems(providers, Linq.firstOrDefault(providers)) Line 160: providersListModel.setIsChangable(true); Line 161: getIsDiscoveredHosts().setEntity(null); Line 162: getIsDiscoveredHosts().setEntity(true); Line 163: } -- To view, visit http://gerrit.ovirt.org/32946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71d1249d86a6b700708391eb19ba98302dd0be4a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
