Roy Golan has posted comments on this change. Change subject: core: Add numa node index when create vm numa node ......................................................................
Patch Set 13: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/27988/13/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java: Line 20: for (VmNumaNode node : vmNumaNodes) { Line 21: Map<String, Object> createVmNumaNode = new HashMap<>(); Line 22: createVmNumaNode.put(VdsProperties.NUMA_NODE_CPU_LIST, NumaUtils.buildStringFromListForNuma(node.getCpuIds())); Line 23: createVmNumaNode.put(VdsProperties.VM_NUMA_NODE_MEM, String.valueOf(node.getMemTotal())); Line 24: createVmNumaNode.put(VdsProperties.NUMA_NODE_INDEX, node.getIndex()); * except for CPU,MEM,INDEX do we need to send something else with it? * add a check in the NumaNodeFactoryTest Line 25: createVmNumaNodes.add(createVmNumaNode); Line 26: } Line 27: return createVmNumaNodes; Line 28: } -- To view, visit http://gerrit.ovirt.org/27988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
