Vered Volansky has uploaded a new change for review.
Change subject: core: cleanups in MoveOrCopyTemplateCommand
......................................................................
core: cleanups in MoveOrCopyTemplateCommand
Fix typo, removed unused method and redundant empty line.
Change-Id: Icb15c84d10d301bb593ad9930e4b1b56b6ab7af5
Signed-off-by: Vered Volansky <vvola...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
1 file changed, 1 insertion(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/32972/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
index 50930c2..d688803 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
@@ -240,19 +240,6 @@
});
}
- protected VM getVmFromSnapshot(Snapshot snapshot) {
- String vmConfiguration = snapshot.getVmConfiguration();
- // active snapshot
- if (vmConfiguration == null) {
- return getVm();
- }
- else {
- VM vm = new VM();
- new SnapshotsManager().updateVmFromConfiguration(vm,
vmConfiguration);
- return vm;
- }
- }
-
@Override
public AuditLogType getAuditLogTypeValue() {
switch (getActionState()) {
@@ -364,7 +351,7 @@
/**
* Space Validations are done using data extracted from the disks. The
disks in question in this command
- * don't have all the needed data, and in order not to contaminate the
command's data structures, as alter
+ * don't have all the needed data, and in order not to contaminate the
command's data structures, an alter
* one is created specifically fo this validation - hence dummy.
* @param disksList
* @return
@@ -519,5 +506,4 @@
diskImage.setStoragePoolId(storagePoolId);
}
}
-
}
--
To view, visit http://gerrit.ovirt.org/32972
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb15c84d10d301bb593ad9930e4b1b56b6ab7af5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
