Eli Mesika has posted comments on this change. Change subject: db:add tab/col name validation to common functions ......................................................................
Patch Set 1: Allon: Change was done after Shirly had an upgrade script that had changed column type for several columns, she had typo in one of the column names but since the function skip those errors, the upgrade script was successful and this was found only in QA. So, the danger of having such mistakes pass the upgrade process leads to fix the behavior and throw an exception in such cases. The only function I think can still be re-entrant and harmless as is is the fn_db_add_column function that skips the work in case that the column already exists -- To view, visit http://gerrit.ovirt.org/32959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5f087f3d47b4f36bb99151a21c2e1016d77b64 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
