Oved Ourfali has posted comments on this change. Change subject: core: use last successful proxy in wait-for-status ......................................................................
Patch Set 3: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/32890/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java: Line 518: // Waiting before first attempt to check the host status. Line 519: // This is done because if we will attempt to get host status immediately Line 520: // in most cases it will not turn from on/off to off/on and we will need Line 521: // to wait a full cycle for it. Line 522: ThreadUtils.sleep(getSleep(actionType, order)); Please add an empty line here. Thanks Line 523: // get a proxy host to be used along the whole wait-for-status loop in order to prevent unnecessary delays when Line 524: // a potential preferred proxy host has connectivity problems and can not access the fenced host PM card Line 525: if (executor.findProxyHost()) { Line 526: while (!statusReached && i <= getRerties()) { -- To view, visit http://gerrit.ovirt.org/32890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7684826be6098e952134366ce480ddb1ca3a2c99 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
