Allon Mureinik has posted comments on this change.

Change subject: core: Get all unregisterd entities for Storage Domain
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/32744/6/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java
File 
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java:

Line 67:     @Test
Line 68:     public void testGetAllEntitiesForStorageDomain() {
Line 69:         List<OvfEntityData> ovfEntityDataList =
Line 70:                 
dao.getAllForStorageDomainByEntityType(FixturesTool.STORAGE_DOAMIN_NFS2_1, 
null);
Line 71:         assertTrue("There should be entities fetched for the specified 
storage domain", !ovfEntityDataList.isEmpty());
> I don't think that the spring jdbc will ever return null for list.
The production code assumes that null is never returned, therefore, we should 
test it.

Come to think about it - please add a test that passes a bogus domain id and 
asserts an empty list is returned.
Line 72:         assertEquals("A Template and a VM should be fetched for the 
specified storage domain",
Line 73:                 2,
Line 74:                 ovfEntityDataList.size());
Line 75:     }


-- 
To view, visit http://gerrit.ovirt.org/32744
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fa749c309381a9f034dc8e6ea499740c33f8990
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to