Alexander Wels has posted comments on this change. Change subject: frontend: NUMA support ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/28299/13/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/numa/NumaSupportPopupPresenterWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/numa/NumaSupportPopupPresenterWidget.java: Line 99: } Line 100: })); Line 101: } Line 102: Line 103: private void modelReady() { make sure to keep the onReveal, you can add new modelReady but keep onReveal. I would keep the setInSlot and getView().setUnassignedGroupPanel in the on reveal, then populate during modelReady. Line 104: setInSlot(TYPE_SetUnassignedPanel, unassignedVNumaNodesPanelPresenterWidget); Line 105: getView().setUnassignedGroupPanel(unassignedVNumaNodesPanelPresenterWidget.getView()); Line 106: unassignedVNumaNodesPanelPresenterWidget.populateView(); Line 107: getView().clear(); -- To view, visit http://gerrit.ovirt.org/28299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0712ea82b87d4fe9fc25f196183136485c0c4381 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
