Daniel Erez has posted comments on this change. Change subject: webadmin: Fix bug in DC selection for an ISO domain attached to multiple DCs ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/32931/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java: Line 214: SearchableListModel searchableListModel = (SearchableListModel) model; Line 215: ArrayList<StorageDomain> domains = Line 216: (ArrayList<StorageDomain>) ((VdcQueryReturnValue) ReturnValue).getReturnValue(); Line 217: for (StorageDomain domain : domains) { Line 218: String guid = these lines are redundant now, please remove... Line 219: domain.getStoragePoolId() != null ? domain.getStoragePoolId().toString() Line 220: : Guid.Empty.toString(); Line 221: domain.setId(domain.getStoragePoolId()); Line 222: } -- To view, visit http://gerrit.ovirt.org/32931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31dd6b0a2908f82bdcb3762c963908865ac88f42 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
