Yair Zaslavsky has posted comments on this change.
Change subject: core: Add BLOB servlet
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/blob/BlobRegistry.java
Line 12: * be used to download files. Servers capable od doing this conversion
can
s/od/of
Line 28: private List<BlobServer> servers = new ArrayList<BlobServer>(1);
Just out of curiosity - why did you use the CTOR? why initial capacity of 1?
Line 41: public synchronized void registerServer(BlobServer server) {
Doron, Juan - can we expect to have some sort of "registration load" (i.e -
lots of registration requests?)
Maybe we should refine the synchronization here, if there is a possible case
for that?
Line 55: public synchronized URL registerBlob(File file) {
Same question as before.
--
To view, visit http://gerrit.ovirt.org/6484
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4726aa4084ebb8f93caf0616aceab10957c16b90
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
