Maor Lipchuk has submitted this change and it was merged. Change subject: core: Allow remove snapshot w/o disks (#825809) ......................................................................
core: Allow remove snapshot w/o disks (#825809) https://bugzilla.redhat.com/825809 Some of the canDoAction validations in RemoveSnapshotCommand implicitly assume that the snapshot contains disks. This patch ignores these validations in case the snapshot does not contain any disks, since they are not valid. Change-Id: Ie65a93e75419b8b63e6c7e46fd9137f3db7684c4 Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java 2 files changed, 121 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie65a93e75419b8b63e6c7e46fd9137f3db7684c4 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
