Xiaolei Shi has posted comments on this change. Change subject: core: Collect vm numa node runtime information ......................................................................
Patch Set 13: Code-Review-1 (3 comments) Some code missing from the previous patch set. I don't know if it caused by the rebase. But it will cause some functionality error. Please hava a check. http://gerrit.ovirt.org/#/c/28096/13/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAODbFacadeImpl.java: Line 238: List<MapSqlParameterSource> vNodeToPnodeInsertions = new ArrayList<>(); Line 239: for (VmNumaNode node : vmNumaNodes) { Line 240: vNodeToPnodeDeletions.add(getCustomMapSqlParameterSource().addValue("vm_numa_node_id", node.getId())); Line 241: for (Pair<Guid, Pair<Boolean, Integer>> pair : node.getVdsNumaNodeList()) { Line 242: vNodeToPnodeInsertions.add(createVnodeToPnodeParametersMapper(pair, node.getId())); The parameter vmNumaNodes will also contain the pinned nodes statistics data. Need to filter out these data, or else there will be duplicated running info in db. Please refer to the previous patch set. Line 243: } Line 244: } Line 245: getCallsHandler().executeStoredProcAsBatch("DeleteUnpinnedNumaNodeMapByVmNumaNodeId", vNodeToPnodeDeletions); Line 246: getCallsHandler().executeStoredProcAsBatch("InsertNumaNodeMap", vNodeToPnodeInsertions); Line 242: vNodeToPnodeInsertions.add(createVnodeToPnodeParametersMapper(pair, node.getId())); Line 243: } Line 244: } Line 245: getCallsHandler().executeStoredProcAsBatch("DeleteUnpinnedNumaNodeMapByVmNumaNodeId", vNodeToPnodeDeletions); Line 246: getCallsHandler().executeStoredProcAsBatch("InsertNumaNodeMap", vNodeToPnodeInsertions); The same as above. Please refer to the previous patch set. Line 247: } Line 248: http://gerrit.ovirt.org/#/c/28096/13/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 2075: } Line 2076: } Line 2077: Line 2078: private void updateVmNumaNodeRuntimeInfo(VmStatistics statistics, VM vm) { Line 2079: if (vm.getRunOnVds() == null) { Missing codes. Please refer to the previous patch set. Line 2080: return; Line 2081: } Line 2082: Line 2083: //Build numa nodes map of the host which the vm is running on with node index as the key -- To view, visit http://gerrit.ovirt.org/28096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
