Martin Peřina has posted comments on this change. Change subject: core: Marshalling regression on fenceNode ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32855/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 475: .withParameter("password", password) Line 476: .withParameter("action", action) Line 477: .withOptionalParameter("secure", secured) Line 478: .withOptionalParameter("options", options) Line 479: .withOptionalParameterAsMap("fencingPolicy", fencingPolicy) Are you sure, that fencingPolicy parameter is not send to VDSM as a part of message if it's null? Because if I remember correctly, I added this part of code to prevent sending fencingPolicy param with null value as this breaks the call on VDSM < 3.5 Line 480: .build(); Line 481: Map<String, Object> response = Line 482: new FutureMap(this.client, request).withResponseKey("power").withResponseType(String.class); Line 483: -- To view, visit http://gerrit.ovirt.org/32855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9a1bc5a818a122a75f8f02385cfcfc26b003400 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
