Omer Frenkel has posted comments on this change. Change subject: core: VM monitoring - no need to handle exception ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/28661/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 234: ? VDSCommandType.GetAllVmStats Line 235: : VDSCommandType.List; Line 236: VDSReturnValue vdsReturnValue = Line 237: getResourceManager().runVdsCommand(commandType, new VdsIdAndVdsVDSCommandParametersBase(vds)); Line 238: runningVms = (Map<Guid, VmInternalData>) vdsReturnValue.getReturnValue(); i miss where do we handle the failure of the fetch Line 239: } Line 240: Line 241: private void refreshCommitedMemory() { Line 242: memCommited = vds.getGuestOverhead(); -- To view, visit http://gerrit.ovirt.org/28661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f037813b52d63c45c97c44e3e6074c009dd5b9a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
