Gilad Chaplik has uploaded a new change for review.

Change subject: restapi: fix NPE in NUMA mapping
......................................................................

restapi: fix NPE in NUMA mapping

Virtual numa node can be pinned to index without specifying
physical numa node.

Change-Id: I0e06436e497d28b93ee47b909041cef9c792b516
Bug-Url: https://bugzilla.redhat.com/######
Signed-off-by: Gilad Chaplik <gchap...@redhat.com>
---
M 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NumaMapper.java
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/02/32902/1

diff --git 
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NumaMapper.java
 
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NumaMapper.java
index c6c9979..f3608f7 100644
--- 
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NumaMapper.java
+++ 
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NumaMapper.java
@@ -68,7 +68,9 @@
             for (Pair<Guid, Pair<Boolean, Integer>> pair : 
entity.getVdsNumaNodeList()) {
                 NumaNodePin pin = new NumaNodePin();
                 pin.setHostNumaNode(new NumaNode());
-                pin.getHostNumaNode().setId(pair.getFirst().toString());
+                if (pair.getFirst() != null) {
+                    pin.getHostNumaNode().setId(pair.getFirst().toString());
+                }
                 pin.setPinned(pair.getSecond().getFirst());
                 pin.setIndex(pair.getSecond().getSecond());
                 pins.getNumaNodePin().add(pin);


-- 
To view, visit http://gerrit.ovirt.org/32902
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e06436e497d28b93ee47b909041cef9c792b516
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to