mooli tayer has posted comments on this change.

Change subject: notifier: modify the oid schema for SNMP notification.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/32895/2/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
File 
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java:

Line 105:             auditLogId = 
AuditLogType.valueOf(event.getName()).getValue();
Line 106:         } catch (IllegalArgumentException e) {
Line 107:             log.warn("Could not find event: " + event.getName() + " 
in auditLogTypes");
Line 108:         }
Line 109:         // TODO link here to snmp notifications@wiki - that should 
have a link to the SNMP mib src.
Removed this.
I will replace with a link once wiki is updated
Line 110: 
Line 111:         // snmpTrapOID -> baseoid.notifications.audit
Line 112:         v2pdu.add(new VariableBinding(SnmpConstants.snmpTrapOID,
Line 113:                                       new 
OID(profile.oid).append(1).append(1)));


-- 
To view, visit http://gerrit.ovirt.org/32895
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib12fd6d48af8c48ffa683376097be14bf83ac0ed
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to