Lior Vernia has posted comments on this change. Change subject: core: allowed to add network label even if Vm using this network is running. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32688/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java: Line 160: if (oldNetwork == null || newNetwork == null) { Line 161: return false; Line 162: } Line 163: Line 164: return Objects.equals(oldNetwork.getName(), newNetwork.getName()) && > I'd like to comment on this: there are just few getters being considered -- I think QoS is relevant. First, there needs to be some validation related to the QoS entity so it should not short-circuit the canDoAction(); and also it's something that should be propagated to hosts (or alternatively renders the network out-of-sync). Line 165: Objects.equals(oldNetwork.getDataCenterId(), newNetwork.getDataCenterId()) && Line 166: Objects.equals(oldNetwork.getId(), newNetwork.getId()) && Line 167: Objects.equals(oldNetwork.getMtu(), newNetwork.getMtu()) && Line 168: Objects.equals(oldNetwork.getName(), newNetwork.getName()) && -- To view, visit http://gerrit.ovirt.org/32688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a658a4e2d4648917a265493cde4749ad15e3ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
