Maor Lipchuk has posted comments on this change. Change subject: core: Add unregistered entities to the ovf tar file ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/32745/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java: Line 184: Line 185: return bufferedOutputStream.toByteArray(); Line 186: } Line 187: Line 188: private void addUnregisteredEntities(List<Pair<Guid, String>> ovfs) { > what if there is a vm with the same id on both the vm table and on the unre It should not happened, once a VM is imported for a Storage Domain, the VM should be removed from the unregistered table for this Storage Domain Line 189: List<OvfEntityData> ovfList = getUnregisteredOVFDataDao().getAllForStorageDomainByEntityType( Line 190: getParameters().getStorageDomainId(), null); Line 191: for (OvfEntityData ovfEntityData : ovfList) { Line 192: Pair<Guid, String> ovfData = new Pair<>(ovfEntityData.getEntityId(), ovfEntityData.getOvfData()); -- To view, visit http://gerrit.ovirt.org/32745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc5fc1c1b704ecbb49fe3d4c2561ec1836093369 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
