Eliraz Levi has posted comments on this change. Change subject: engine: fixing bug no validation AddSubnetToProvider ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32565/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java: Line 519: setValidTab(TabName.SUBNET_TAB, subnetValid); Line 520: setValidTab(TabName.PROFILES_TAB, profilesValid); Line 521: Line 522: ValidationCompleteEvent.fire(getEventBus(), this); Line 523: return getName().getIsValid() && getVLanTag().getIsValid() && getDescription().getIsValid() && subnetValid; > Well, if you rebase on master now there's an even more elegant solution, yo Done Line 524: } Line 525: Line 526: protected boolean isCustomMtu() { Line 527: return MtuSelector.customMtu == getMtuSelector().getSelectedItem(); -- To view, visit http://gerrit.ovirt.org/32565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaac8748c9b47dfc7a622efaa887980333f5bc56d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
