Juan Hernandez has posted comments on this change. Change subject: build: Add category to module definition ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32845/1/build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/ModulesMojo.java File build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/ModulesMojo.java: Line 162: } Line 163: Line 164: // Attach the generated zip file containing the modules as an Line 165: // additional artifact: Line 166: getLog().info("Attaching modules artifact \"" + modulesArchive + "\""); > Do you mean that instead of "modules" there should be String.format("%s-mod Yes, not strictly required, but I think is better that way. Line 167: projectHelper.attachArtifact(project, "zip", "modules", modulesArchive); Line 168: } Line 169: Line 170: private void createModule(Module module) throws MojoExecutionException { -- To view, visit http://gerrit.ovirt.org/32845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief6e14398bec4378c2153514bb69667835c3d331 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
