Tomer Saban has posted comments on this change.

Change subject: webadmin: Fix typo for QoS
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/32755/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-09-10 14:53:05 +0300
Line 4: Commit:     Tomer Saban <tsa...@redhat.com>
Line 5: CommitDate: 2014-09-10 14:57:08 +0300
Line 6: 
Line 7: Constant in the qos sub tab in the data centers tab "Write IOps" was 
accidently named "Read IOps".
> congratulation for your first patch :-)
Done
Line 8: 
Line 9: Change-Id: Ic65a15815cc276cd3ec9d0290946a97813c7a434


http://gerrit.ovirt.org/#/c/32755/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java:

Line 3835:     @DefaultStringValue("Read IOps")
Line 3836:     String storageQosIopsRead();
Line 3837: 
Line 3838:     @DefaultStringValue("Write IOps")
Line 3839:      String storageQosIopsWrite();
> configure you IDE to use 4 spaces instead of tab, and apply it everywhere.
Done
Line 3840: 
Line 3841:     @DefaultStringValue("New")
Line 3842:     String newStorageQos();
Line 3843: 


-- 
To view, visit http://gerrit.ovirt.org/32755
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic65a15815cc276cd3ec9d0290946a97813c7a434
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsa...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to