Piotr Kliczewski has posted comments on this change. Change subject: core: monitoring - separate Host Monitoring and Vm Moniting ......................................................................
Patch Set 12: (6 comments) http://gerrit.ovirt.org/#/c/28173/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java: Line 24: super(parameters); Line 25: } Line 26: Line 27: @Override Line 28: protected void executeVmCommand() { How do we make sure that vdsManager is not null? Do we expect NPEs here? Line 29: final VM vm = getParameters().getVm(); Line 30: vm.setLastStartTime(new Date()); Line 31: // if the VM is not suspended, it means that if there is 'hibernation volume' Line 32: // set, it is actually memory from snapshot, thus it should be cleared right http://gerrit.ovirt.org/#/c/28173/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java: Line 21: } Line 22: Line 23: @Override Line 24: protected void executeVmCommand() { Line 25: How do we make sure that vdsManager is not null? Line 26: final DestroyVmVDSCommandParameters parameters = getParameters(); Line 27: ResourceManager.getInstance().RemoveAsyncRunningVm(parameters.getVmId()); Line 28: Line 29: final VM curVm = DbFacade.getInstance().getVmDao().get(parameters.getVmId()); http://gerrit.ovirt.org/#/c/28173/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HibernateVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HibernateVDSCommand.java: Line 10: super(parameters); Line 11: } Line 12: Line 13: @Override Line 14: protected void executeVmCommand() { How do we make sure that vdsManager is not null? Line 15: VDSReturnValue retVal = runHibernateBrokerVDSCommand(); Line 16: if (retVal.getSucceeded()) { Line 17: vmManager.succededToHibernate(); Line 18: getVDSReturnValue().setSucceeded(true); http://gerrit.ovirt.org/#/c/28173/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java: Line 19: super(parameters); Line 20: } Line 21: Line 22: @Override Line 23: protected void executeVmCommand() { How do we make sure that vdsManager is not null? Line 24: MigrateBrokerVDSCommand<?> command = new MigrateBrokerVDSCommand<>(getParameters()); Line 25: command.execute(); Line 26: VDSReturnValue vdsReturnValue = command.getVDSReturnValue(); Line 27: http://gerrit.ovirt.org/#/c/28173/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResumeVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResumeVDSCommand.java: Line 13: } Line 14: Line 15: @Override Line 16: protected void executeVmCommand() { Line 17: ResumeVDSCommandParameters parameters = getParameters(); How do we make sure that vdsManager is not null? Line 18: VMStatus retval = VMStatus.Unknown; Line 19: ResumeBrokerVDSCommand<VdsAndVmIDVDSParametersBase> command = Line 20: new ResumeBrokerVDSCommand<VdsAndVmIDVDSParametersBase>(parameters); Line 21: command.execute(); http://gerrit.ovirt.org/#/c/28173/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 134: this.vmDict = getDbFacade().getVmDao().getAllRunningByVds(vds.getId()); Line 135: vmManagers = new HashMap<>(vmDict.size()); // max size is the one's that in the db Line 136: } Line 137: Line 138: public void begin() { It looks like it is performMonitoring method or something similar. 'begin' suggest that there is next step. Line 139: try { Line 140: lockVmsManager(); Line 141: refreshVmStats(); Line 142: saveVmsToDb(); -- To view, visit http://gerrit.ovirt.org/28173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54c6091a3996c23a4b70c7ef89412d34f1b58e34 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
