Liron Aravot has posted comments on this change. Change subject: engine: placeholders of child commands aren't cleared when failing during the CDA phase ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32790/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 345: if (actionAllowed) { Line 346: execute(); Line 347: } else { Line 348: getReturnValue().setCanDoAction(false); Line 349: clearChildAsyncTasksWithOutVdsmId(); IMO the solution here should be that the placeholders will be inserted just before the execute phase, there's no need to insert them before the cda. any reason to not do that? Line 350: } Line 351: } finally { Line 352: freeLockExecute(); Line 353: clearAsyncTasksWithOutVdsmId(); -- To view, visit http://gerrit.ovirt.org/32790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie77a00b0071c92d074d837768af012c80374169f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
