Ravi Nori has posted comments on this change. Change subject: engine: Add AddVmTemplateCommand to command executer framework ......................................................................
Patch Set 3: (2 comments) Please see comments http://gerrit.ovirt.org/#/c/31180/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 212: } Line 213: Line 214: @Override Line 215: protected void executeCommand() { Line 216: persistCommand(getParameters().getParentCommand()); Please rebase and remove the above, it is no longer needed Line 217: // get vm status from db to check its really down before locking Line 218: // relevant only if template created from vm Line 219: if (isVmInDb) { Line 220: VmDynamic vmDynamic = DbFacade.getInstance().getVmDynamicDao().get(getVmId()); Line 305: pendingAsyncTasks = !getReturnValue().getVdsmTaskIdList().isEmpty(); Line 306: if (!pendingAsyncTasks) { Line 307: endSuccessfullySynchronous(); Line 308: } Line 309: setCommandStatus(CommandStatus.SUCCEEDED); Please rebase and remove the above, it is no longer needed Line 310: } Line 311: Line 312: private boolean doClusterRelatedChecks() { Line 313: // A Template cannot be added in a cluster without a defined architecture -- To view, visit http://gerrit.ovirt.org/31180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib47982264f535dcf38cd4f9319f842d75ebccd5d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
