Lior Vernia has posted comments on this change. Change subject: webadmin: integrate CidrValidator to frontend ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/32541/6/frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/CidrValidationTest.java File frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/CidrValidationTest.java: Line 39: Line 40: @Test Line 41: public void checkCidrFormatValidation(){ Line 42: if (!validNetworkAddressExpectedResult){ Line 43: assertEquals("Failed to validate CIDR's format: "+cidr, validNetworkAddressExpectedResult, validation.validate(cidr).getSuccess());//$NON-NLS-1$ Please add spaces between the string, the '+' and the cidr variable, it's not very readable at the moment. Line 44: } Line 45: Line 46: else{ Line 47: assertEquals("Failed to validate CIDR's format: "+cidr, validCidrFormatExpectedResult, validation.validate(cidr).getSuccess());//$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/32541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib09d8943b0265960a35f3dd328dae20247b69fd3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
