Omer Frenkel has posted comments on this change. Change subject: core: monitoring - make Vm a managed resource ......................................................................
Patch Set 4: (2 comments) do we need the beans.xml? http://gerrit.ovirt.org/#/c/32586/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java: Line 450: public VmManager getVmManager(Guid vmId) { Line 451: return vmManagers.putIfAbsent(vmId, new VmManager(vmId)); Line 452: } Line 453: Line 454: public void onVmDelete(@Observes @VmDeleted Guid vmId) { no need to define this annotation? Line 455: vmManagers.remove(vmId); Line 456: } http://gerrit.ovirt.org/#/c/32586/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java: Line 51: TransactionSupport.executeInNewTransaction( Line 52: new TransactionMethod<Object>() { Line 53: @Override Line 54: public Object runInTransaction() { Line 55: VmDynamic vmDynamic = db().getVmDynamicDao().get(id); you can just use getVmDynamicDao() Line 56: vmDynamic.setStatus(VMStatus.SavingState); Line 57: update(vmDynamic); Line 58: return null; Line 59: } -- To view, visit http://gerrit.ovirt.org/32586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia711cc2d69082ecc03325362291faa4a38aa6c0a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
