Alon Bar-Lev has posted comments on this change. Change subject: aaa: use Authn.Capabilities.AUTHENTICATE_CREDENTIALS correctly ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32768/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java: Line 357: private ExtMap authenticate(AuthenticationProfile profile, String user, String password) { Line 358: ExtensionProxy authnExtension = profile.getAuthn(); Line 359: ExtMap authRecord = null; Line 360: Line 361: if (isCredentialsAuth(authnExtension)) { > care to elaborate why mapper is used only in case of credentials auth? this is per documentation... :) see mapper. but anyway.... without credentials we do not have user... so no point in doing so. I am aware that we reach this point only if we do have user... however, this is safeguard if code is moved or misread. Line 362: ExtensionProxy mapper = profile.getMapper(); Line 363: if (mapper != null) { Line 364: user = mapper.invoke(new ExtMap().mput( Line 365: Base.InvokeKeys.COMMAND, -- To view, visit http://gerrit.ovirt.org/32768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed1d4523ddf2bcefb3f1b1be868e4caf6c04ad7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
