Federico Simoncelli has posted comments on this change. Change subject: core: check storage domains status on master deactivation ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32517/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java: Line 131: if (!activeDomains.isEmpty() && dataDomains.isEmpty()) { Line 132: return failCanDoAction(VdcBllMessages.ERROR_CANNOT_DEACTIVATE_MASTER_WITH_NON_DATA_DOMAINS); Line 133: } Line 134: Line 135: List<StorageDomain> busyDomains = LinqUtils.filter(domains, new Predicate<StorageDomain>() { > I'm OK with having this here for the meanwhile. Deactivating the master domain while it's busy is not a valid operation. I think the only "busy" state valid for the master domain is Locked (since PreparingForMaintenance, Detaching and Activating are not possible iirc). Line 136: @Override Line 137: public boolean eval(StorageDomain storageDomain) { Line 138: return storageDomain.getStatus().isStorageDomainInProcess(); Line 139: } -- To view, visit http://gerrit.ovirt.org/32517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28228f2ad3ce555aafc9ea03d44aebeb12bbf0cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
