Yair Zaslavsky has posted comments on this change. Change subject: core: refactoring in CommandsFactory ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32572/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java: Line 60: } Line 61: Line 62: public static <P extends VdcActionParametersBase> CommandBase<P> createCommand(VdcActionType action, P parameters, CommandContext commandContext) { Line 63: try { Line 64: CommandBase<P> result = instantiateCommand(action, parameters, commandContext); several ideas here - a. remove the temp variable result b. have Injector.injectMembers return CommandBase c. turn all the try block into one liner as result of a + b. Line 65: Line 66: Injector.injectMembers(result); Line 67: return result; Line 68: } -- To view, visit http://gerrit.ovirt.org/32572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1d15d69afad9cefad95d0d266a495e3d95cd6e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
