Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: The text and buttons not aligned in Create VM dialog ......................................................................
webadmin: The text and buttons not aligned in Create VM dialog The http://gerrit.ovirt.org/#/c/30821 enhanced the "Guide Me" dialog so also the bigger text will fit in. The problem with this patch is that it uses the "display: flex" which is not supported by firefox 17 and firefox 17 is the only browser supported by oVirt. So this patch "reverts" this fix and applyes the one proposed here: http://gerrit.ovirt.org/#/c/30861/ which does not look so nice but works also on older browsers. Change-Id: Ifcb74f036476fb8544d1f15d26a0ef92e2eeed46 Bug-Url: https://bugzilla.redhat.com/1135965 Signed-off-by: Tomas Jelinek <tjeli...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 3 files changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/32733/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java index 1b9a966..82358bc 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java @@ -36,8 +36,8 @@ @Template("<table cellspacing='0' cellpadding='0'><tr>" + "<td style='background: url({2});width:2px;'></td>" + "<td style='text-align:center;'>" + - "<div class='db_bg_image {5} {6}' style='background: url({3}) repeat-x; height: 20px; display: flex;'>" + - "<span style='vertical-align: middle; line-height: 20px; margin-top: 2px;' class=\"db_image_container\">{0}</span><div style='line-height: 19px;'>{1}</div></div>" + + "<div class='db_bg_image {5} {6}' style='background: url({3}) repeat-x; height: 20px;'>" + + "<span style='vertical-align: middle; line-height: 20px;' class=\"db_image_container\">{0}</span><div class=\"db_text\">{1}</div></div>" + "</td>" + "<td style='background: url({4});width:2px;'></td>" + "</tr></table>") diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml index 8a2a6f4..b59f7b4 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml @@ -24,7 +24,7 @@ } .actionButtonContent { - min-width: 250px; + min-width: 415px; text-align: left; } diff --git a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css index 668d4a5..7626c82 100644 --- a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css +++ b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css @@ -301,6 +301,10 @@ .mtev_buttonPanel_pfly_fix label { padding-left: 3px !important; } +.db_text { + position: relative !important; + top: -1px; +} .tslp_sliderButton_pfly_fix { top: -3px !important; } @@ -393,6 +397,11 @@ .gpv_flowPanel_pfly_fix { padding: 4px; } +.gpv_flowPanel_pfly_fix .db_text { + position: relative !important; + top: -23px !important; + left: 20px !important; +} .gpv_flowPanel_pfly_fix .db_image_container img { position: relative !important; top: -3px !important; -- To view, visit http://gerrit.ovirt.org/32733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifcb74f036476fb8544d1f15d26a0ef92e2eeed46 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
