Allon Mureinik has posted comments on this change. Change subject: core: Report unreachable domain names when setting host as non operational ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/32712/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java: Line 215: StorageDomainStatic storageDomain = DbFacade.getInstance().getStorageDomainStaticDao().get(domainId); Line 216: Map<String, String> customLogValues = null; Line 217: if (storageDomain != null) { Line 218: customLogValues = new HashMap<>(); Line 219: customLogValues.put("StorageDomainNames", storageDomain.getName()); I'd use Collections.singletonMap Line 220: } Line 221: vdsNonOperational(vdsId, reason, logCommand, domainId, customLogValues); Line 222: } Line 223: -- To view, visit http://gerrit.ovirt.org/32712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b68d1c2a387c84e97137b27f00956870fd96357 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
