Ravi Nori has uploaded a new change for review. Change subject: engine : Fix issues with ActionGroup ......................................................................
engine : Fix issues with ActionGroup The changes made in 1c23ff57d14b531427d causes issues in frontend while displaying the list of permissions in new/edit role dialog Change-Id: Ie60948707b4d5809b79e5a66c733f4dc96f9596c Bug-Url: https://bugzilla.redhat.com/1138732 Signed-off-by: Ravi Nori <rn...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java 2 files changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/32714/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java index 1496915..9b3ceb2 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java @@ -1281,7 +1281,7 @@ builder.append(" ID: ").append(permSubject.getObjectId()) .append(" Type: ").append(permSubject.getObjectType()); if (permSubject.getActionGroup() != null) { - builder.append(permSubject.getActionGroup().toString()); + builder.append("Action group " + permSubject.getActionGroup().name() + " with role type " + permSubject.getActionGroup().getRoleType().name()); } } } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java index 0db427b..6c4275d 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java @@ -185,9 +185,4 @@ public int getAvailableInModes() { return applicationMode; } - - @Override - public String toString() { - return "Action group " + this.name() + " with role type " + this.roleType.name(); - } } -- To view, visit http://gerrit.ovirt.org/32714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie60948707b4d5809b79e5a66c733f4dc96f9596c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
