Simone Tiraboschi has uploaded a new change for review. Change subject: packaging: setup: removing default storage type question ......................................................................
packaging: setup: removing default storage type question Reviewing it, we found that the question is superfluous since almost all the user will choose 'shared'. Change-Id: I90cde87b8aaf9cc5b76737f2869b8ab25228c444 Bug-Url: https://bugzilla.redhat.com/1102021 Signed-off-by: Simone Tiraboschi <stira...@redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py 1 file changed, 1 insertion(+), 19 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/11/32711/1 diff --git a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py index 7734a29..3e4fa7d 100644 --- a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py +++ b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py @@ -27,7 +27,6 @@ from otopi import plugin from ovirt_engine_setup import constants as osetupcons -from ovirt_engine_setup import dialog @util.export @@ -57,7 +56,7 @@ ) self.environment.setdefault( osetupcons.ConfigEnv.STORAGE_IS_LOCAL, - None + osetupcons.Defaults.DEFAULT_CONFIG_STORAGE_IS_LOCAL ) @plugin.event( @@ -91,23 +90,6 @@ self.environment[ osetupcons.ConfigEnv.STORAGE_TYPE ] = None - - if self.environment[ - osetupcons.ConfigEnv.STORAGE_IS_LOCAL - ] is None: - self.environment[ - osetupcons.ConfigEnv.STORAGE_IS_LOCAL - ] = dialog.queryBoolean( - dialog=self.dialog, - name='OVESETUP_CONFIG_STORAGE_IS_LOCAL', - note=_( - 'Default storage type: (@VALUES@) [@DEFAULT@]: ' - ), - prompt=True, - true=_('Local'), - false=_('Shared'), - default=osetupcons.Defaults.DEFAULT_CONFIG_STORAGE_IS_LOCAL, - ) @plugin.event( stage=plugin.Stages.STAGE_MISC, -- To view, visit http://gerrit.ovirt.org/32711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I90cde87b8aaf9cc5b76737f2869b8ab25228c444 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
