Simone Tiraboschi has uploaded a new change for review. Change subject: packaging: setup: removing default storage type question ......................................................................
packaging: setup: removing default storage type question Review it we found that the question is superfluous since almost all the user will choose 'shared'. Change-Id: Ia7e1ac239b4ad37580bc7ce0863734c60efa7cf5 Bug-Url: https://bugzilla.redhat.com/1102021 Signed-off-by: Simone Tiraboschi <stira...@redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py 1 file changed, 2 insertions(+), 21 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/32709/1 diff --git a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py index 5475998..8c34c03 100644 --- a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py +++ b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py @@ -28,9 +28,7 @@ from ovirt_engine_setup import constants as osetupcons from ovirt_engine_setup.engine import constants as oenginecons -from ovirt_engine_setup.engine_common \ - import constants as oengcommcons -from ovirt_engine_setup import dialog +from ovirt_engine_setup.engine_common import constants as oengcommcons @util.export @@ -60,7 +58,7 @@ ) self.environment.setdefault( osetupcons.ConfigEnv.STORAGE_IS_LOCAL, - None + oenginecons.Defaults.DEFAULT_CONFIG_STORAGE_IS_LOCAL ) @plugin.event( @@ -95,23 +93,6 @@ self.environment[ osetupcons.ConfigEnv.STORAGE_TYPE ] = None - - if self.environment[ - osetupcons.ConfigEnv.STORAGE_IS_LOCAL - ] is None: - self.environment[ - osetupcons.ConfigEnv.STORAGE_IS_LOCAL - ] = dialog.queryBoolean( - dialog=self.dialog, - name='OVESETUP_CONFIG_STORAGE_IS_LOCAL', - note=_( - 'Default storage type: (@VALUES@) [@DEFAULT@]: ' - ), - prompt=True, - true=_('Local'), - false=_('Shared'), - default=oenginecons.Defaults.DEFAULT_CONFIG_STORAGE_IS_LOCAL, - ) @plugin.event( stage=plugin.Stages.STAGE_MISC, -- To view, visit http://gerrit.ovirt.org/32709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7e1ac239b4ad37580bc7ce0863734c60efa7cf5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
