Alexander Wels has posted comments on this change. Change subject: frontend: Fix validation of UnitVmModel ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32645/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 2616: getTotalCPUCores().getIsValid() && Line 2617: getSerialNumberPolicy().getCustomSerialNumber().getIsValid()); Line 2618: Line 2619: Line 2620: boolean isValid = behaviorValid && allTabsValid(); This one does not appear to be the same as the original. For instance I don't see it using customPropertySheetValid && getName().getIsValid() anywhere. I might be missing something. But from a tab validity point of view this is correct. But from a validation point of view I don't know 100%. Line 2621: Line 2622: getValid().setEntity(isValid); Line 2623: ValidationCompleteEvent.fire(getEventBus(), this); Line 2624: return isValid; -- To view, visit http://gerrit.ovirt.org/32645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabba7f93a0541292a1a4c82b675ab0faf141b9b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
