Alona Kaplan has posted comments on this change. Change subject: webadmin: Re-assign roles when network is detached ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/32254/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java: Line 119: private void changeIsAttached(ClusterNetworkModel clusterNetworkModel, Boolean value) { Line 120: clusterNetworkModel.setAttached(value); Line 121: if (!value) { Line 122: if (clusterNetworkModel.isDisplayNetwork()) { Line 123: updateDisplayNetwork(clusterNetworkModel, false); Why do you need to call 'refreshNetworksTable()' from this context? It is already called from the places that called 'changeIsAttached(..)'? Line 124: } Line 125: if (clusterNetworkModel.isMigrationNetwork()) { Line 126: updateMigrationNetwork(clusterNetworkModel, false); Line 127: } Line 122: if (clusterNetworkModel.isDisplayNetwork()) { Line 123: updateDisplayNetwork(clusterNetworkModel, false); Line 124: } Line 125: if (clusterNetworkModel.isMigrationNetwork()) { Line 126: updateMigrationNetwork(clusterNetworkModel, false); same Line 127: } Line 128: if (clusterNetworkModel.isRequired()) { Line 129: clusterNetworkModel.setRequired(false); Line 130: } -- To view, visit http://gerrit.ovirt.org/32254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72a9b4a46a32014b31f8981fbe0e8750352dd80e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
