Mike Kolesnik has posted comments on this change. Change subject: core: IdParameters should contain @NotNull validation ......................................................................
Patch Set 13: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/30569/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java: This class should override getValidationGroups with "RemoveEntity" group.. Line 1: package org.ovirt.engine.core.bll; Line 2: Line 3: import java.util.Collections; Line 4: import java.util.List; -- To view, visit http://gerrit.ovirt.org/30569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cda909ffc16aa3b844faa7c2e7cd323a0769db1 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches