Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Avoid engine DB password in answerfile if providing ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32646/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py: Line 167: for k, v in obj.__dict__.items(): Line 168: if hasattr(v, '__osetup_attrs__'): Line 169: key = v.fget(None) Line 170: if key == oenginecons.EngineDBEnv.PASSWORD: Line 171: v.__osetup_attrs__['answerfile'] = False I'd rather have something similar to summary_condition. If in the future we want to prevent some other keys based on some calculated conditions, we do not want copies of this loop scattered around in the code. Line 172: Line 173: @plugin.event( Line 174: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 175: priority=plugin.Stages.PRIORITY_LAST, -- To view, visit http://gerrit.ovirt.org/32646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fb9d2c10d3809c68430084f6212eaa191d5ca21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
