Oved Ourfali has submitted this change and it was merged. Change subject: core: setupNetworks not able to configure bridge ......................................................................
core: setupNetworks not able to configure bridge For 2 calls we use ThreadPoolUtil. It was used to provide async network call for xmlrpc. Jsonrpc is async so from its prespective it makes no sense to use it. In order to keep the communication interface unchanged we need to returned Future. The future checked whether the call was executed not whether the response arrived. This patch makes sure that we wait for response and expose this information correctly. Bug-Url: https://bugzilla.redhat.com/1136876 Change-Id: I70bfa5d7f154a13f7d52f7710eb109de1da0b82c Signed-off-by: pkliczewski <piotr.kliczew...@gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M ovirt-engine.spec.in M pom.xml 4 files changed, 106 insertions(+), 25 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70bfa5d7f154a13f7d52f7710eb109de1da0b82c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
